Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6684: Small link update request for the rucss_firewall_ips admin notice #7086

Merged

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Nov 4, 2024

Description

Fixes #6684
Change the rucss_firewall_ips admin notice link.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

None

Technical description

Documentation

None

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld requested a review from a team November 4, 2024 02:40
@Miraeld Miraeld self-assigned this Nov 4, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c2e65f01 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c2e65f0) Report Missing Report Missing Report Missing
Head commit (1638f3c) 38112 16690 43.79%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7086) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Miraeld, thank you for this change.
Confirmed links are updated correctly on PR for both EN and FR List of IPs links.

@hanna-meda hanna-meda added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 1a09742 Nov 4, 2024
13 checks passed
@hanna-meda hanna-meda deleted the enhancement/6684-change-rucss-firewall-doc-link branch November 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small link update request for the rucss_firewall_ips admin notice
3 participants