Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7153: Update plugin family package #7154

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jeawhanlee
Copy link
Contributor

Description

Update the plugin family package to the latest version.

Fixes #7153
New package version handles translations.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Issue is currently visible on trunk

Technical description

Documentation

The new version of the package handles translation using the translation functions and some configurations in the composer.json file to update the package with the correct text domain.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@jeawhanlee jeawhanlee self-assigned this Nov 28, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (df52190) 38228 16731 43.77%
Head commit (f187de4) 38228 (+0) 16731 (+0) 43.77% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7154) 17 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jeawhanlee jeawhanlee marked this pull request as ready for review November 28, 2024 19:36
@jeawhanlee
Copy link
Contributor Author

Translations now work as expected for fr, same shall be for other langs

Screenshot 2024-11-28 at 20 36 30

@jeawhanlee jeawhanlee added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Nov 28, 2024
@jeawhanlee jeawhanlee requested a review from a team November 28, 2024 19:38
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jeawhanlee, for this PR.

To check translations, I followed these steps:

  1. Checkout branch and run npm run makepot (this updated the rocket.pot file here)
  2. Open any language file (.po) in poedit
  3. From Translation > Update from POT file... > browse, and select the rocket.pot file updated in step 1
  4. Translate the new entries one by one and save changes

I could see that translations were correctly applied in UI.
Confirming this as done based on this comment.

@hanna-meda hanna-meda added this pull request to the merge queue Dec 19, 2024
Merged via the queue into develop with commit 9acceae Dec 19, 2024
14 of 15 checks passed
@hanna-meda hanna-meda deleted the enhancement/7153-update-plugin-family-package branch December 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin family package
3 participants