Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7170 Fonts download data measurement #7173

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

remyperona
Copy link
Contributor

Description

Fixes #7170

Type of change

Detailed scenario

With rocket debug log enabled, load a page. Data will be available in the log:

  • Number of fonts downloaded for each CSS file
  • Download time for each font
  • Average download time of fonts in each CSS file

Technical description

Documentation

Count the number of fonts downloaded in each CSS files. Measure the download time for each font. Use those values to generate an average download time per CSS file.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I did not introduce unnecessary complexity.

Unticked items justification

No tests to add

@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Dec 6, 2024
@remyperona remyperona added this to the 3.18 milestone Dec 6, 2024
@remyperona remyperona requested a review from a team December 6, 2024 16:18
@remyperona remyperona self-assigned this Dec 6, 2024
Copy link

codacy-production bot commented Dec 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -0.10%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0c3c6fa) 38438 16880 43.91%
Head commit (9436176) 38449 (+11) 16891 (+11) 43.93% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7173) 11 11 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@remyperona remyperona linked an issue Dec 6, 2024 that may be closed by this pull request
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes/questions

inc/Engine/Media/Fonts/Filesystem.php Outdated Show resolved Hide resolved
inc/Engine/Media/Fonts/Filesystem.php Outdated Show resolved Hide resolved
@wordpressfan wordpressfan merged commit 0afcb6a into feature/host-google-fonts Dec 12, 2024
13 checks passed
@wordpressfan wordpressfan deleted the task/7170-fonts-download-time branch December 12, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding more measurements for fonts download
2 participants