[TITAN-291] - Re-create Customer Testimonials section in React #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossoMaguire
commented
Apr 6, 2023
| @@ -42,7 +43,7 @@ | |||
| --wpe--content--max-width: 620px; | |||
| --wpe--section--padding-y: 3rem; | |||
| --wpe--container--padding-x: 15px; | |||
| --wpe--container--max-width: 1000px; | |||
| --wpe--container--max-width: 1200px; | |||
There was a problem hiding this comment.
This is conducive with the BC Blueprint width - works better in the sections
alvarocavalcanti
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also contains [TITAN-292 - Re-create on sale products section in React](https://wpengine.atlassian.net/jira/software/c/projects/TITAN/boards/1122?modal=detail&selectedIssue=TITAN-292)
Created the component for the
TestimonialSectionandTestimonialCardchild components.Repeated the
ProductSectionfrom previous PR to make theOn Salesection - just added more items withcompareAtPricevalues in the mock data to produce these products.Re-organised the
Containerto be within the components so I could get the full width grey background in the Testimonial section. Added some supporting CSS.Screenshots