NO-JIRA: build: 📌 Pinning Node version to match Atlas environment #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switched to a different SCSS transform lib
alvarocavalcanti
changed the title
…to TITAN-NO-JIRA-Tests-fix-deps
RossoMaguire
previously approved these changes
Apr 14, 2023
…to TITAN-NO-JIRA-Tests-fix-deps
alvarocavalcanti
dismissed stale reviews from mikepawlinski and RossoMaguire
via
119067f
mikepawlinski
approved these changes
Apr 17, 2023
RossoMaguire
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're adding a
.nvmrcfile to pin the Node version for the project, keeping it in sync with Atlas' version.We also replaced
jest-transform-scsswithjest-css-modules-transformdue to a dependency conflict in Atlas build environment.Testing
Screenshots
Documentation Changes
Dependent PRs