Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TITAN-314] Removed node-sass and request #52

Merged
merged 3 commits into from
May 3, 2023
Merged

[TITAN-314] Removed node-sass and request #52

merged 3 commits into from
May 3, 2023

Conversation

alvarocavalcanti
Copy link
Member

Description

This PR adds removes the dependency to both node-sass and request libraries.

https://wpengine.atlassian.net/browse/TITAN-314

Testing

  • Included/Didn't include unit tests. Execute the test suite using npm run test and all tests should pass.

  • Manual testing instructions:

    • Step 1
    • Step 2
    • Step 3
    • Expected result

Screenshots

Documentation Changes

Dependent PRs

@alvarocavalcanti alvarocavalcanti requested a review from a team as a code owner May 2, 2023 17:30
RossoMaguire
RossoMaguire approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@RossoMaguire RossoMaguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran npm ci and create a new build that worked with no issues

@alvarocavalcanti alvarocavalcanti merged commit f2c439d into main May 3, 2023
@alvarocavalcanti alvarocavalcanti deleted the TITAN-314 branch May 3, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossoMaguire RossoMaguire RossoMaguire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarocavalcanti @RossoMaguire