[TITAN-363] - UI Adjustments #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossoMaguire
commented
May 30, 2023
| padding: 1rem; | ||
| min-width: 115px; |
There was a problem hiding this comment.
This just makes all CTA buttons a standard width rather than depending on the text
RossoMaguire
commented
May 30, 2023
| @@ -1,4 +1,5 @@ | |||
| .component { | |||
| color: var(--wpe--main--color); | |||
| background-color: var(--wpe--main--background-color); | |||
| min-height: 100vh; | |||
There was a problem hiding this comment.
Footer snaps to bottom with this property on the main content wrapper
RossoMaguire
commented
May 30, 2023
| blue: 'blue', | ||
| purple: 'purple', | ||
| charcoal: 'black', | ||
| red: 'red', |
There was a problem hiding this comment.
Can be extended for others that are not CSS colours, here it is charcoal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes up some outstanding UI issues that we have identified:
charcoalvariant wasn't showing a black swatch because that is not a native colour in CSS. So I created aVARIANT_MAPconst that the user can extend to map variants to CSS colours.Testing
npm run devand test the changes listed above in various browsers