Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _blocks.scss #1425

Merged
merged 1 commit into from
May 19, 2023

Conversation

shaunsantacruz
Copy link
Contributor

@shaunsantacruz shaunsantacruz commented May 15, 2023

Tasks

Description

Add z-index so it is properly compiled. Without it, it adds the z-index function to the stylesheet creating an invalid value. This can be reproduced by adding a cover block with some text and then inspect it.

Add z-index so it is properly compiled. Without it, it simply is adding the z-index function to the stylesheet.
@shaunsantacruz shaunsantacruz requested a review from a team as a code owner May 15, 2023 18:22
@headless-platform-by-wp-engine

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

⚠️ No Changeset found

Latest commit: cc95e4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@josephfusco josephfusco self-assigned this May 19, 2023
@josephfusco
Copy link
Member

Hey @shaunsantacruz this looks good! Thank you for completing our CLA requirement and for the contribution!

(The failing jobs is a known issue due to forks not having appropriate access to a few of the workflows)

@josephfusco josephfusco merged commit e32fd7f into wpengine:canary May 19, 2023
@headless-platform-by-wp-engine

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

@shaunsantacruz shaunsantacruz deleted the shaunsantacruz-patch-1 branch June 9, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants