Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Block Support Example #1565

Merged
merged 17 commits into from
Oct 4, 2023
Merged

✨ Block Support Example #1565

merged 17 commits into from
Oct 4, 2023

Conversation

josephfusco
Copy link
Member

@josephfusco josephfusco commented Sep 6, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

These changes add a basic example of getting started with blocks within Faust.
I have not generated a changeset given that this is a non-distributed example.

Testing

Pull down this branch nojira-block-support-example and run the example project.

npm run dev -w @faustwp/block-support-example

The example only contains a front-page template in order to demonstrate block content on the homepage.

When reviewing, consider the following:

  • Can this example be reduced any further?
  • Are there any aspects of configuring block support within Faust.js that are missing from this example?

Screenshots

The page assigned as "Front Page" on faustexample.wpengine.com:

The page assigned as Front Page on faustexample.wpengine.com

The "Front Page" rendered using Faust.js:

The Front Page rendered using Faust.js

Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>

# Conflicts:
#	package-lock.json
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@wpengine wpengine deleted a comment from github-actions bot Sep 6, 2023
@wpengine wpengine deleted a comment from github-actions bot Sep 6, 2023
@wpengine wpengine deleted a comment from github-actions bot Sep 6, 2023
Comment on lines +6 to +7
"predev": "faust generatePossibleTypes && faust generateGlobalStylesheet",
"prebuild": "faust generatePossibleTypes && faust generateGlobalStylesheet",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephfusco josephfusco marked this pull request as ready for review September 6, 2023 18:39
@josephfusco josephfusco requested a review from a team as a code owner September 6, 2023 18:39
@josephfusco josephfusco mentioned this pull request Sep 6, 2023
8 tasks
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@wpengine wpengine deleted a comment from github-actions bot Sep 6, 2023
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@wpengine wpengine deleted a comment from github-actions bot Sep 6, 2023
@wpengine wpengine deleted a comment from github-actions bot Sep 6, 2023
@wpengine wpengine deleted a comment from github-actions bot Sep 25, 2023
@wpengine wpengine deleted a comment from github-actions bot Sep 25, 2023
@wpengine wpengine deleted a comment from github-actions bot Sep 25, 2023
@wpengine wpengine deleted a comment from github-actions bot Oct 1, 2023
@wpengine wpengine deleted a comment from changeset-bot bot Oct 1, 2023
@josephfusco josephfusco merged commit 4c4e600 into canary Oct 4, 2023
14 checks passed
@josephfusco josephfusco deleted the nojira-block-support-example branch October 4, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants