Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of deep paths more clear in app router package #1581

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Sep 19, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

We have to use deep paths for some Faust core modules because Next.js 13 throws an error with barrel exports that include client components (ie any React Component) that doesn't have the use client directive at the top. This PR adds a separate file to keep an inventory of these imports with a comment describing why this is being done. For more info:

vercel/next.js#12557 (comment)

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner September 19, 2023 15:54
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: 0ce1c77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@blakewilson blakewilson merged commit 507cc4e into canary Sep 19, 2023
13 checks passed
@blakewilson blakewilson deleted the faust-core-utils branch September 19, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants