Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App router example improvements #1588

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Conversation

blakewilson
Copy link
Contributor

@blakewilson blakewilson commented Sep 22, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

This PR adds a few final improvements to the App Router example project:

Related Issue(s):

Testing

Screenshots

Pages are now supported, not just posts:
Screenshot 2023-09-22 at 10 01 34 AM

gated-content page now renamed to my-account. Also, a logout button was added:
Screenshot 2023-09-22 at 10 01 18 AM

What you see when you visit a preview route without being authenticated:
Screenshot 2023-09-22 at 10 02 42 AM

What you see when you visit a preview route while authenticated (This relies on wp-graphql/wp-graphql#1673 being resolved):
Screenshot 2023-09-22 at 10 03 34 AM

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner September 22, 2023 14:23
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

⚠️ No Changeset found

Latest commit: 79fc4f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 242.98 KB (🟡 +340 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@blakewilson blakewilson changed the title App router example clean up App router example improvements Sep 22, 2023
Copy link
Contributor

@TeresaGobble TeresaGobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Blake! Thank you for adding these improvements! 😊

examples/next/app-router/components/please-login.tsx Outdated Show resolved Hide resolved
Co-authored-by: Teresa Gobble <teresagobble@gmail.com>
@blakewilson blakewilson merged commit 6ae2a43 into canary Sep 22, 2023
13 checks passed
@blakewilson blakewilson deleted the app-router-example-clean-up branch September 22, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants