-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App router example improvements #1588
Conversation
…s/pages for our catch all route
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
242.98 KB (🟡 +340 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Blake! Thank you for adding these improvements! 😊
Co-authored-by: Teresa Gobble <teresagobble@gmail.com>
Tasks
Description
This PR adds a few final improvements to the App Router example project:
/gated-content
to/my-account
Related Issue(s):
Testing
Screenshots
Pages are now supported, not just posts:
gated-content
page now renamed tomy-account
. Also, a logout button was added:What you see when you visit a preview route without being authenticated:
What you see when you visit a preview route while authenticated (This relies on wp-graphql/wp-graphql#1673 being resolved):
Documentation Changes
Dependant PRs