Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Force cli package to use @wordpress/scripts #1617

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Oct 19, 2023

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

  • This PR forces the cli blockset command to use the @wordpress/scripts package as part of the build process avoiding any potential confusion.

Related Issue(s):

Testing

  • clean up your node_modules package.
  • Install the project dependencies again with npm i.
  • run npm run blockset -w examples/next/block-support it should use the --package=@wordpress/scripts in the log files
npm verb argv "exec" "wp-scripts" "start" "--package" "@wordpress/scripts" "--loglevel" "verbose" "--" "--no-watch" "--webpack-src-dir=wp-blocks" "--output-path=/Users/theo.despoudis/Workspace/faustjs/examples/next/block-support/.faust/build"

Screenshots

Documentation Changes

Dependant PRs

@theodesp theodesp requested a review from a team as a code owner October 19, 2023 11:47
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 5c255b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@faustwp/cli Patch
@faustwp/block-support-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@blakewilson blakewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @theodesp! Just tested manually and things are now compiling as expected.

Screenshot 2023-10-19 at 8 37 19 AM

@theodesp theodesp merged commit 03ee9e8 into canary Oct 19, 2023
13 checks passed
@theodesp theodesp deleted the nojira-force-package-wordpress-scripts branch October 19, 2023 14:44
@ghost
Copy link

ghost commented Nov 29, 2023

I get the following error now if I run yarn blockset:
[webpack-cli] Error: Unknown option '--package=@wordpress/scripts'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants