Skip to content

Commit

Permalink
[CICD-496] Fix autogenerated release notes (#96)
Browse files Browse the repository at this point in the history
[CICD-496] Use EOF syntax when generating release notes

Newline characters are not currently encoded properly when release notes are autogenerated.

This PR uses the EOF syntax (now recommended by GitHub) to handle encoding of the multi-line release note string.
  • Loading branch information
mike-day authored Aug 30, 2024
1 parent 51a7046 commit 75b8cf5
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions .github/actions/get-release-notes/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ runs:
- id: notes
run: |
notes=$(node ${{ github.action_path }}/getReleaseNotes ${{ inputs.version }} ${{ inputs.changelog }})
notes="${notes//'%'/'%25'}"
notes="${notes//$'\n'/'%0A'}"
notes="${notes//$'\r'/'%0D'}"
echo "RELEASE_NOTES=$notes" >> $GITHUB_OUTPUT
echo "RELEASE_NOTES<<EOF" >> $GITHUB_OUTPUT
echo "$notes" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
shell: bash

0 comments on commit 75b8cf5

Please sign in to comment.