Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redux Robotics links in third party libraries/devices #2256

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

guineawheek
Copy link
Contributor

No description provided.

Copy link
Member

@Daltz333 Daltz333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: I'm bad and can't read.

source/docs/software/can-devices/third-party-devices.rst Outdated Show resolved Hide resolved
@guineawheek guineawheek marked this pull request as draft May 20, 2023 07:30
Redux Robotics
--------------

Redux Robotics currently offers the Canandcoder CAN-enabled magnetic encoder. The vendordep is necessary for CAN-based operation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about vendordep seems a little odd because there's no link to the vendordep so it leaves the reader searching. It's also true of every other item on this page, but not stated. Recommend clarifying that it supports two modes of operation and library is only needed for CAN or removing, since that is covered in the linked manual.

@guineawheek guineawheek marked this pull request as ready for review August 2, 2023 03:37
@guineawheek
Copy link
Contributor Author

the rebase is not right lemme try fixing this

@guineawheek
Copy link
Contributor Author

ok the changes are no longer merging in other stuff

@Daltz333 Daltz333 merged commit 7ac0fed into wpilibsuite:main Aug 2, 2023
9 checks passed
pjbuterbaugh pushed a commit to pjbuterbaugh/frc-docs that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants