Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Make C++ example for advantagescope swerve states compilable #2599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nobody5050
Copy link
Contributor

When I was initially implementing this in my codebase the example in the docs confused me because although it seemed straightforward it wouldn’t actually compile. The publisher needs a std::span of states rather than a vector as indicated by the docs. While this is definitely not the most concise implementation, (it’s ripped from our season code) it’s a lot more helpful in my opinion.

std::span<frc::SwerveModuleState, 4> states(states_vec.begin(),
states_vec.end());

publisher.Set(states);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be necessary to explicitly create a std::span. It should work to just pass states_vec directly to the publisher, as there's an implicit conversion from std::vector to std::span.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should also be possible to simply use double-braces here, although I've not tested it:

swervePublisher.Set(
            {{
              frontLeftState,
              frontRightState,
              backLeftState,
              backRightState
            }}
          );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants