Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #2740

Closed
wants to merge 5 commits into from
Closed

Fixed typo #2740

wants to merge 5 commits into from

Conversation

Steephydra393
Copy link
Contributor

from wpi::Log::BooleanLogEntry to wpi::log::BooleanLogEntry for C++. Notice the L in Log, its supposed to be lowercase

TheTripleV
TheTripleV previously approved these changes Sep 13, 2024
@TheTripleV TheTripleV changed the base branch from stable to main September 13, 2024 23:18
@TheTripleV TheTripleV dismissed their stale review September 13, 2024 23:18

The base branch was changed.

@sciencewhiz sciencewhiz changed the base branch from main to stable September 15, 2024 00:03
@sciencewhiz
Copy link
Collaborator

sciencewhiz commented Sep 15, 2024

Thanks for the fix. Per https://docs.wpilib.org/en/stable/docs/contributing/frc-docs/contribution-guidelines.html#creating-a-pr the PRs should be based on the main branch and not stable. Please change the base branch of your PR to main.

@PeterJohnson PeterJohnson changed the base branch from stable to main September 28, 2024 03:04
@sciencewhiz sciencewhiz mentioned this pull request Oct 6, 2024
@sciencewhiz sciencewhiz closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants