Skipping code blocks and fixing docs build. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on another PR I ran into this bug on my test website. I had a test document with only an HTML code block and found out unescaped HTML was added to the meta tag: ```html <meta property="og:description" content="<meta property="og:image" content="_images/normal.jpg" /> <img alt="_images/normal.jpg" src="_images/normal.jpg" />" /> <meta property="og:image" content="_images/normal.jpg" /> ``` Fixing this by skipping literal blocks. Also fixed docs build. I was getting the exception: `AttributeError: 'Values' object has no attribute 'section_self_link'` This was caused by sphinx-doc/sphinx#9825. Updating dependencies fixed the issue.
Daltz333
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another PR I ran into this bug on my test website. I had a test document with only an HTML code block and found out unescaped HTML was added to the meta tag:
Fixing this by skipping literal blocks.
Also fixed docs build. I was getting the exception:
AttributeError: 'Values' object has no attribute 'section_self_link'This was caused by sphinx-doc/sphinx#9825. Updating dependencies fixed the issue.