Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quotations in Open Graph description when smart quotes are disabled. #49

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

ItayZiv
Copy link
Collaborator

@ItayZiv ItayZiv commented Dec 4, 2021

Fixes #46
Replaces the normal quotation mark with the proper HTML ". This problem would only appear when smart quotes are disabled in Sphinx via smartquotes = False

@Daltz333 Daltz333 merged commit 8569b1c into wpilibsuite:main Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotes aren't escaped in the Open Graph description, causing some descriptions to end early
2 participants