Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(sui-footer): sui footer b, strong style #419

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

creador-dev
Copy link
Member

No description provided.

@creador-dev creador-dev added the bug Something isn't working label Dec 29, 2021
@creador-dev creador-dev changed the title 🐛 fix(sui footer): sui footer b, strong style 🐛 fix(sui-footer): sui footer b, strong style Jan 17, 2022
@creador-dev creador-dev changed the base branch from development to version/2.12.3 February 10, 2022 06:24
@iamleigh iamleigh self-requested a review February 25, 2022 23:01
@@ -17,6 +17,11 @@
}
}

b,
strong {
font-weight: $font--weight-bold;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creador-dev there's no need to make b or strong font-weight bold, but instead, to make a difference, we need to make footer text regular so when b or strong tags are in use can apply by default the correct font-weight.

Base automatically changed from version/2.12.3 to development February 26, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants