Skip to content

Commit

Permalink
- (s2Member/s2Member Pro) **Security Enhancement:** This release remo…
Browse files Browse the repository at this point in the history
…ves the `%%user_pass%%` Replacement Code from the API Registration Notification email that is sent to a site owner; i.e., when/if it is configured by a site owner. Props @patdumond see [Issue #954](#954). This Replacement Code was removed as a security precaution.
  • Loading branch information
jaswrks committed Apr 18, 2017
1 parent f4ab185 commit 3bc99fc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

- (s2Member Pro) **Stripe Bug Fix:** This releases corrects a seemingly rare conflict between s2Member and Stripe on certain mobile devices and in certain scenarios. In a case we examined, there was a problematic CSS `z-index` setting in the s2Member source code that was, at times, causing problems in the stacking order, which resulted in a user's inability to enter details into the Stripe popup form. In this release, s2Member's customization of the `z-index` stacking order has been removed entirely, as it is no longer necessary in the latest revision of the Stripe popup, which already handles `z-index` adequately. Props @jaspuduf for reporting and for helping us diagnose the problem. See [Issue #1057](https://github.com/websharks/s2member/issues/1057).

- (s2Member/s2Member Pro) **Security Enhancement:** This release removes the `%%user_pass%%` Replacement Code from the API Registration Notification email that is sent to a site owner; i.e., when/if it is configured by a site owner. Props @patdumond see [Issue #954](https://github.com/websharks/s2member/issues/954). This Replacement Code was removed as a security precaution.

- (s2Member/s2Member Pro) **Bug Fix:** Resolving internal warning: 'PHP Warning: Parameter 2 to c_ws_plugin__s2member_querys::_query_level_access_coms() expected to be a reference, value given'. This was resolved by removing the strict 'by reference' requirement from the list of parameters requested by s2Member.

- (s2Member/s2Member Pro) **Bug Fix:** Resolving internal warning: 'PHP Warning: Illegal string offset 'user_id' in s2member/src/includes/classes/sc-eots-in.inc.php'. This was resolved by typecasting `$attr` to an array in cases where WordPress core passes this as a string; e.g., when there are no attributes.
Expand Down
2 changes: 1 addition & 1 deletion src/includes/classes/registrations.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ public static function configure_user_registration($user_id = '', $password = ''
$msg .= 'user_full_name: %%user_full_name%%'."\n";
$msg .= 'user_email: %%user_email%%'."\n";
$msg .= 'user_login: %%user_login%%'."\n";
$msg .= 'user_pass: %%user_pass%%'."\n";
//$msg .= 'user_pass: %%user_pass%%'."\n";
$msg .= 'user_ip: %%user_ip%%'."\n";
$msg .= 'user_id: %%user_id%%'."\n";

Expand Down
2 changes: 1 addition & 1 deletion src/includes/menu-pages/menu-pages.css
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ div.ws-menu-page > :not(.notice):not(.updated):not(.error) div.ws-menu-page-hr
{
height : 1px;
line-height : 1px;
background : #DDDDDD;
background : #bdca9a;
margin : 10px 0 10px 0;
}
div.ws-menu-page > :not(.notice):not(.updated):not(.error) .ws-menu-page-error
Expand Down

0 comments on commit 3bc99fc

Please sign in to comment.