Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving current working directory #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix resolving current working directory #45

wants to merge 3 commits into from

Conversation

vladimyr
Copy link
Contributor

Define WREN_PATH_MAX recursively using PATH_MAX or use a fallback.
Handle UV_ENOBUFS error (provided buffer is too small to store resolved path).

bjorn
bjorn reviewed Jun 16, 2020
View reviewed changes
src/module/os.c Outdated Show resolved Hide resolved
@vladimyr
Fix resolving current working directory
9a43ee6 
Define `WREN_PATH_MAX` recursively using `PATH_MAX`
or use fallback.
Handle `UV_ENOBUFS` error.
bjorn
bjorn reviewed Jun 16, 2020
View reviewed changes
src/module/os.c Show resolved Hide resolved
@joshgoebel
Copy link
Contributor

What is the case when the path is longer than 4096 characters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn bjorn bjorn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladimyr @joshgoebel @bjorn