Fix typo in cmake find netCDF causing failure on blank responses #2135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: netcdf, cmake
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Certain versions of netCDF with particular configurations return a blank when queried with
nc-config
. To prevent a null argument expansion in CMake we should check for variable emptiness and if empty assume the queried feature is not present. There is a typo copied from the FindnetCDF-Fortran.cmake module causing this check to never get exercised leading to failed configuration due to syntax errors.Solution:
Correct the typo to reference the netCDF variables rather than the netCDF-Fortran ones.
TESTS CONDUCTED:
--has-szlib ->
)RELEASE NOTE: Bug fix in CMake FindnetCDF.cmake for empty --has-* nc-config fields