Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vale version #2139

Merged
merged 4 commits into from
May 9, 2024
Merged

Update Vale version #2139

merged 4 commits into from
May 9, 2024

Conversation

CollierCZ
Copy link
Member

@CollierCZ CollierCZ commented May 3, 2024

Current Vale check is incorrectly flagging some headings as being incorrectly capitalized even when they involve explicit exceptions. See example. This blocks PRs updating the guide, such as #2136

Based on errata-ai/vale#735, an update to the Vale version might fix this.


📚 Documentation preview 📚: https://writethedocs-www--2139.org.readthedocs.build/

@CollierCZ
Copy link
Member Author

CollierCZ commented May 3, 2024

Seems successful based on the list of errors under Vale Guide Linter in this action. The listed exceptions are no longer flagged (there are other false positives that could be added to the exceptions list, perhaps later when I have time [not just during lunch break]).

@plaindocs
Copy link
Contributor

Oh nice one, I'll take a look shortly.

@plaindocs
Copy link
Contributor

I wonder if it fixes #2133 as well :-D

@CollierCZ CollierCZ enabled auto-merge May 9, 2024 09:08
@CollierCZ CollierCZ merged commit e593324 into main May 9, 2024
7 checks passed
@CollierCZ CollierCZ deleted the update-vale branch May 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants