splits CI build #2229
splits CI build #2229
Conversation
There was a problem hiding this comment.
This looks great to me.
@mxsasha want to put eyes on this before we merge it? tl;dr, I opened #2226 to add a Windows CI build to help keep WTD buildable on Windows. And @kdschlosser suggested splitting the build up, and did so, as well as adding in Windows.
|
And those three waiting jobs are I assume from master branch, and will be removed when we merge this in. |
|
They should disappear when this gets merged. Like how everything now builds in parallel? a lot more efficient this way especially now that you have the Linux and the Windows builds which take some time to run. |
|
It's also better having it split up because if you need to make a change to the CI and there is a problem that comes up it doesn't break everything. It only ends up breaking a small portion of it. |
|
Yep, love that last point. :-) |
|
ok, with the second 👍 I'll merge this in. |
|
Thanks guys. I believe this is definitely a step in the right direction since the CI is getting larger. The ability to have the CI run the tests and builds in parallel is the way to go. |
|
For posterity, if you have specific rules mention in branch protection rules, you have to go update those after changing the CI names. 👍 |
|
we kind of touched base on that a bit when you asked about those 3 rules and them disappearing. I said they "should" and if they didn't then you would need to go into the actions and make adjustments as needed. looks like you figured that out tho. |
|
Absolutely not pointing at you there ;-), I just read the first half and missed the second. All good. |
|
no worries m8. This is a learning experience for us all, and that is the reason why we are doing this stuff. It's to learn and to share knowledge. |
Splits the CI build into separate files and removes the need to decompress an archive of the HTML output. This also adds building using Windows as well.
📚 Documentation preview 📚: https://writethedocs-www--2229.org.readthedocs.build/