Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show other websites for meetups #2242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Show other websites for meetups #2242

wants to merge 2 commits into from

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Oct 16, 2024

@rosewms this is the zero effort approach:

  • delete the website key from all meetups (we weren't using it)
  • add a tiny snippet of template to show the website key if it exists as Elsewhere:
    image
  • now if you want a linkedin profile instead, add it as website: cool-linked-in-url here

Caveats:

  • still need a meetup ID
  • can only have one website
  • cannot customize the link title

Let me know if this isn't enough, and I'll tweak further.


📚 Documentation preview 📚: https://writethedocs-www--2242.org.readthedocs.build/

@@ -35,6 +35,13 @@
</div>
{% endif %}

{# Other internet presence #}
{% if meetup['website'] %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about doing this with links and allowing multiple?

Something like:

- links:
  - Meetup: https://meetup...
  - LinkedIn: https://linked..

That way you can control the link copy and allow multiple if needed?

Comment on lines +39 to +43
{% if meetup['website'] %}
<div>
Elsewhere: <a href="{{ meetup['website']}}">{{ meetup['website'] }}</a>
</div>
{% endif %}
Copy link
Member

@ericholscher ericholscher Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% if meetup['website'] %}
<div>
Elsewhere: <a href="{{ meetup['website']}}">{{ meetup['website'] }}</a>
</div>
{% endif %}
{% if meetup['links'} %}
<ul>
{% for text, link in meetup['links'].items() %}
<li>
<a href="{{ link }]">{{ text }}</a>
</li>
{% endfor %}
</ul>
{% endif %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants