⬆️: Upgrade Expo SDK to 48 #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
chore
|
/azp run deploy-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tksugimoto
requested changes
Apr 24, 2023
creature-water-valley
force-pushed
the
feature/upgrade-expo-48
branch
from
bfe39ef
to
23f2c88
Compare
github-actions
bot
added
the
ci
Error: Hooks cannot be defined inside tests. Hook of type "beforeEach" is nested within
….activateKeepAwakeAsync Add web support to expo-keep-awake(expo/expo@b41269b)
creature-water-valley
force-pushed
the
feature/upgrade-expo-48
branch
from
23f2c88
to
727c7d6
Compare
github-actions
bot
removed
the
ci
tksugimoto
reviewed
Apr 25, 2023
node_modules配下の構成例がわかりづらかったので、@expo/config-pluginsのバージョンを例として明示
4 tasks
in-a-paddy
reviewed
Apr 27, 2023
example-app/SantokuApp/prebuild/local/ios/LocalSantokuApp/AppDelegate.mm
Show resolved
Hide resolved
tksugimoto
reviewed
May 8, 2023
website/docs/react-native/santoku/maintenance/enhance/expo-48-upgrade.mdx
Outdated
Show resolved
Hide resolved
# Conflicts: # example-app/SantokuApp/jest/__mocks__/@react-native-firebase/messaging.ts
tksugimoto
reviewed
May 8, 2023
website/docs/react-native/santoku/maintenance/enhance/expo-48-upgrade.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Takashi Sugimoto <tksugimoto@users.noreply.github.com>
tksugimoto
approved these changes
May 8, 2023
25 tasks
in-a-paddy
reviewed
May 9, 2023
website/docs/react-native/santoku/maintenance/enhance/expo-48-upgrade.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: In-a-Paddy <44867563+in-a-paddy@users.noreply.github.com>
in-a-paddy
approved these changes
May 9, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What's done
npm install expo@^48.0.0を実行してExpo SDKをアップグレードnpx expo install --fixを実行してExpo管理のライブラリをアップグレード@expo/config-pluginsをdevDependenciesに追加expoや@react-native-firebase/appが依存ライブラリとして追加している@expo/config-pluginsのバージョンが違い、@expo/config-pluginsに適用するパッチのパスが変わってしまうdevDependenciesに@expo/cliで使用する@expo/config-pluginsと同じバージョンを追加することで、パッチを適用するパスが固定されるようにするnpx expo instlall --fixで更新されないライブラリの更新node_modules、package-lock.jsonを削除して、npm iを実行@expo/config-pluginsのパッチファイルを更新expo-splash-screenのファイルをアップデートしたバージョンにリネームapp.config.jsのjsEngineをhermesに変更npm run prebuildbuckconfigの削除.gitignoreの更新expo-random->expo-cryptoへの移行expo-keep-awakeのactivateKeepAwakeが非推奨になったため、activateKeepAwakeAsyncを使用するように変更@types/react-nativeの削除react-nativeからOmitをimportしていた箇所の修正（OverlayBackdrop.tsx）managed-license.jsの更新BSD-3-ClauseライセンスのエイリアスにBSD 3-Clauseを追加renovate5.jsonの更新@types/react-nativejest-expoexpo-randomFlatListでデータが0件の場合にscrollToEndを呼び出すとエラーになる問題の対処としてパッチを追加react-native-datetimepicker/datetimepickerで一部Propsがdeprecatedになった問題の対応npm run prebuild:[local/stg/prod]Tests
以下のコマンドをこのプルリクエストのコメントとして投稿すると、
Azure Pipeline上でSantokuAppをビルドしてDeployGateへアップロードできます。
Devices
Other (messages to reviewers, concerns, etc.)
何かあれば記載してください。
なければ「なし」と記載してください。