Add required changes for gateway spec conformation test #1249
Triggered via pull request
November 3, 2023 08:22
Tharsanan1
Tharsanan1
synchronize
#1833
Status
Failure
Total duration
4m 40s
Artifacts
–
Annotations
10 errors
|
build
const HttpRouteController should be HTTPRouteController
|
|
build
exported function AreConditionsSame should have comment or be unexported
|
|
build
if block ends with a continue statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
|
|
build
struct field GatewayHttpRoutes should be GatewayHTTPRoutes
|
|
build
this block is empty, you can remove it
|
|
build
type HttpRouteReconciler should be HTTPRouteReconciler
|
|
build
func NewHttpRouteController should be NewHTTPRouteController
|
|
build
comment on exported type HttpRouteReconciler should be of the form "HttpRouteReconciler ..." (with optional leading article)
|
|
build
exported const ConditionTypeProgrammed should have comment (or a comment on this block) or be unexported
|
|
build
exported type ReferencedGatewaysAndCondition should have comment or be unexported
|