Add required changes for gateway spec conformation test #1845
Triggered via pull request
November 3, 2023 08:22
Tharsanan1
Tharsanan1
synchronize
#1833
Status
Failure
Total duration
12m 8s
Artifacts
–
integration-test.yml
on: pull_request_target
build_adapter
/
build
8m 33s
build_common_controller
/
build
5m 44s
build_enforcer
/
build
8m 53s
build_router
/
build
11m 53s
build_ratelimiter
/
build
1m 32s
build_config
/
build
5m 19s
build_idpds
/
build
4m 23s
build_idpui
/
build
2m 19s
runs_go_integration_tests_on_pull_request_target
0s
runs_cucumber_integration_tests_on_pull_request_target
0s
Annotations
12 errors
|
build_common_controller / build
comment on exported function NewGatewayClassController should be of the form "NewGatewayClassController ..."
|
|
build_common_controller / build
Process completed with exit code 1.
|
|
build_adapter / build
struct field GatewayHttpRoutes should be GatewayHTTPRoutes
|
|
build_adapter / build
exported function AreConditionsSame should have comment or be unexported
|
|
build_adapter / build
method handleHttpRoutes should be handleHTTPRoutes
|
|
build_adapter / build
method getHttpRoutesForGateway should be getHTTPRoutesForGateway
|
|
build_adapter / build
type HttpRouteReconciler should be HTTPRouteReconciler
|
|
build_adapter / build
const HttpRouteController should be HTTPRouteController
|
|
build_adapter / build
func NewHttpRouteController should be NewHTTPRouteController
|
|
build_adapter / build
if block ends with a continue statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
|
|
build_adapter / build
comment on exported type HttpRouteReconciler should be of the form "HttpRouteReconciler ..." (with optional leading article)
|
|
build_adapter / build
exported const ConditionTypeProgrammed should have comment (or a comment on this block) or be unexported
|