Skip to content

Commit

Permalink
Remove apk conf changes
Browse files Browse the repository at this point in the history
  • Loading branch information
ashera96 committed Oct 31, 2023
1 parent f2340a0 commit d084b8c
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 31 deletions.
8 changes: 0 additions & 8 deletions runtime/config-deployer-service/ballerina/APIClient.bal
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,6 @@ public class APIClient {
apiVersion: apkConf.'version,
basePath: self.returnFullBasePath(apkConf.basePath, apkConf.'version),
isDefaultVersion: apkConf.defaultVersion,
subscriptionValidation: apkConf.subscriptionValidation,
organization: organization.name,
definitionPath: apkConf.definitionPath,
environment: apkConf.environment
Expand Down Expand Up @@ -573,14 +572,7 @@ public class APIClient {
defaultSpecData.responseInterceptors = [item];
}
}
SubscriptionValidation[]? subscriptionValidation = apkConf.subscriptionValidation;
// TODO(Ashera): Need to implement subscription validation API policy CR creation for config deployer approach
// if corsConfiguration is CORSConfiguration {
// model:CORSPolicy? cORSPolicy = self.retrieveCORSPolicyDetails(apiArtifact, apkConf, corsConfiguration, organization);
// if cORSPolicy is model:CORSPolicy {
// defaultSpecData.cORSPolicy = cORSPolicy;
// }
// }
CORSConfiguration? corsConfiguration = apkConf.corsConfiguration;
if corsConfiguration is CORSConfiguration {
model:CORSPolicy? cORSPolicy = self.retrieveCORSPolicyDetails(apiArtifact, apkConf, corsConfiguration, organization);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ public type APISpec record {|
string apiType;
string apiVersion;
string basePath;
string organization;
string organization;
boolean isDefaultVersion?;
boolean subscriptionValidation?;
string definitionFileRef?;
string environment?;
string definitionPath?;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ components:
type: string
description: |
Environment of the API
subscriptionValidation:
type: boolean
description: |
Denotes whether subscription validation is enabled for the API
endpointConfigurations:
$ref: "#/components/schemas/EndpointConfigurations"
operations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
"type": "string",
"description": "Environment of the API"
},
"subscriptionValidation": {
"type": "boolean",
"description": "Denotes whether subscription validation is enabled for the API"
},
"endpointConfigurations": {
"$ref": "#/schemas/EndpointConfigurations",
"description": "Configuration for different endpoints of the API."
Expand Down
2 changes: 0 additions & 2 deletions runtime/config-deployer-service/ballerina/types.bal
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,6 @@ public type APKConf record {
boolean defaultVersion = false;
# Environment of the API
string environment?;
# Denotes whether subscription validation is enabled for the API
boolean subscriptionValidation = false;
EndpointConfigurations endpointConfigurations?;
APKOperations[] operations?;
APIOperationPolicies apiPolicies?;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
"type": "string",
"description": "Environment of the API"
},
"subscriptionValidation": {
"type": "boolean",
"description": "Denotes whether subscription validation is enabled for the API"
},
"endpointConfigurations": {
"$ref": "#/schemas/EndpointConfigurations",
"description": "Configuration for different endpoints of the API."
Expand Down
3 changes: 0 additions & 3 deletions runtime/runtime-ui/schema/apk-conf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ properties:
defaultVersion:
type: boolean
description: Is this the default version of the API
subscriptionValidation:
type: boolean
description: Denotes whether subscription validation is enabled for the API
endpointConfigurations:
"$ref": "#/schemas/EndpointConfigurations"
description: Configuration for different endpoints of the API.
Expand Down
4 changes: 0 additions & 4 deletions runtime/runtime-ui/schema/apk-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
"type": "string",
"description": "Environment of the API"
},
"subscriptionValidation": {
"type": "boolean",
"description": "Denotes whether subscription validation is enabled for the API"
},
"endpointConfigurations": {
"$ref": "#/schemas/EndpointConfigurations",
"description": "Configuration for different endpoints of the API."
Expand Down

0 comments on commit d084b8c

Please sign in to comment.