Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny policy implementation in enforcer #1832

Closed
wants to merge 4 commits into from

Conversation

sgayangi
Copy link
Contributor

@sgayangi sgayangi commented Oct 18, 2023

Purpose

Part of #1781
Adds a deny filter to the enforcer

@sgayangi sgayangi marked this pull request as draft October 18, 2023 05:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a8155ab) 26.00% compared to head (1a8b08e) 23.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   26.00%   23.91%   -2.10%     
==========================================
  Files         250      116     -134     
  Lines       29536    14219   -15317     
  Branches     4894     2201    -2693     
==========================================
- Hits         7680     3400    -4280     
+ Misses      21594    10688   -10906     
+ Partials      262      131     -131     
Flag Coverage Δ
adapter 25.56% <ø> (ø)
common-controller 1.11% <ø> (ø)
config-deployer-service 28.34% <ø> (ø)
idp-domain-service ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 134 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgayangi sgayangi force-pushed the #1781-deny-policy-impl branch from 3bd8593 to 1a8b08e Compare October 18, 2023 06:39
@sgayangi sgayangi force-pushed the #1781-deny-policy-impl branch from 35d6b50 to d8b4258 Compare December 6, 2023 05:35
@sgayangi sgayangi marked this pull request as ready for review December 6, 2023 06:46
@sgayangi sgayangi changed the title Deny policy implementation Deny policy implementation in enforcer Dec 6, 2023
@sgayangi sgayangi force-pushed the #1781-deny-policy-impl branch from d8b4258 to 12c018a Compare December 6, 2023 08:27
@sgayangi sgayangi marked this pull request as draft December 6, 2023 08:27
@sgayangi sgayangi force-pushed the #1781-deny-policy-impl branch from 12c018a to f396049 Compare December 6, 2023 08:34
@sgayangi
Copy link
Contributor Author

This feature was put on hold - will reopen PR as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants