Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tokenissuer #1940

Closed
wants to merge 1 commit into from
Closed

refactor tokenissuer #1940

wants to merge 1 commit into from

Conversation

tharindu1st
Copy link
Contributor

refactor tokenissuer

@tharindu1st tharindu1st added the trigger-action When this includes apk actions getting trigger for pr label Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98fafb9) 26.53% compared to head (66fcea4) 26.52%.
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
- Coverage   26.53%   26.52%   -0.02%     
==========================================
  Files         124      124              
  Lines       14516    14523       +7     
  Branches     2575     2575              
==========================================
  Hits         3852     3852              
- Misses      10540    10547       +7     
  Partials      124      124              
Flag Coverage Δ
adapter 25.18% <ø> (+0.59%) ⬆️
common-controller 3.45% <ø> (-1.18%) ⬇️
config-deployer-service 26.80% <ø> (ø)
idp-domain-service 80.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jan 9, 2024
@tharindu1st tharindu1st added the trigger-action When this includes apk actions getting trigger for pr label Jan 9, 2024
// }
// UpdateEnforcerJWTIssuers(jwtIssuerMapping)
// return ctrl.Result{}, nil
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove commented code.

@@ -0,0 +1,27 @@
package org.wso2.apk.enforcer.subscription;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header?

@@ -0,0 +1,27 @@
package org.wso2.apk.enforcer.subscription;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header? Please check other locations.

@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jan 11, 2024
@tharindu1st tharindu1st added the trigger-action When this includes apk actions getting trigger for pr label Jan 11, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jan 14, 2024
@tharindu1st tharindu1st added the trigger-action When this includes apk actions getting trigger for pr label Jan 14, 2024
Comment on lines +1553 to +1557
if (tokenIssuerBuilder_ == null) {
return tokenIssuer_ == null ? org.wso2.apk.enforcer.discovery.subscription.TokenIssuer.getDefaultInstance() : tokenIssuer_;
} else {
return tokenIssuerBuilder_.getMessage();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (tokenIssuerBuilder_ == null) {
return tokenIssuer_ == null ? org.wso2.apk.enforcer.discovery.subscription.TokenIssuer.getDefaultInstance() : tokenIssuer_;
} else {
return tokenIssuerBuilder_.getMessage();
}
if (tokenIssuerBuilder_ == null) {
return tokenIssuer_ == null ? org.wso2.apk.enforcer.discovery.subscription.TokenIssuer.getDefaultInstance() : tokenIssuer_;
}
return tokenIssuerBuilder_.getMessage();

@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants