Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret for analytics URL and token #2303

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

sgayangi
Copy link
Contributor

@sgayangi sgayangi commented Apr 6, 2024

Purpose

Fixes #2265

Sample values.yaml configuration for Choreo analytics:

      gatewayRuntime:
        analytics:
          enabled: true
          publishers:
            - enabled: true
              type: "default"
              secretName: "default-analytics-secret"
            - enabled: true
              type: "moesif"
              secretName: "moesif-secret"

@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Apr 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.76%. Comparing base (4413d98) to head (dd80a33).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
+ Coverage   25.75%   27.76%   +2.01%     
==========================================
  Files         115      124       +9     
  Lines       14366    14917     +551     
  Branches     2450     2696     +246     
==========================================
+ Hits         3700     4142     +442     
- Misses      10529    10638     +109     
  Partials      137      137              
Flag Coverage Δ
adapter 27.34% <ø> (ø)
common-controller 4.07% <ø> (ø)
config-deployer-service 26.03% <ø> (ø)
idp-domain-service 80.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 7, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Apr 7, 2024
@Krishanx92 Krishanx92 merged commit 91f833d into wso2:main Apr 8, 2024
12 of 13 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 8, 2024
@sgayangi sgayangi changed the title Add secret for choreo analytics URL and token Add secret for analytics URL and token Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics URL and token should be taken from a secret
4 participants