Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KeystoreUtils #4139

Draft
wants to merge 1 commit into
base: 4.10.x
Choose a base branch
from
Draft

Conversation

hwupathum
Copy link

Summary

This pull request includes several changes to the KeystoreUtils class in the org.wso2.carbon.utils package. The changes focus on updating how the default file type for keystores is handled and improving error handling for unsupported file types.

Key changes include:

Default File Type Handling:

  • Removed the FALLBACK_TENANTED_KEYSTORE_FILE_TYPE constant and updated the defaultFileType method to return JKS.name() instead. [1] [2]
  • Removed the defaultFileType constant from the StoreFileType enum.

Error Handling and Logic Improvement:

  • Updated the getKeyStoreFileType method to handle the super tenant domain name case separately and added improved error logging for unsupported file types.
  • Updated the getKeystoreInstance method to use StoreFileType.PKCS12.name() for comparison instead of the removed defaultFileType constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant