Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes several changes to the
KeystoreUtils
class in theorg.wso2.carbon.utils
package. The changes focus on updating how the default file type for keystores is handled and improving error handling for unsupported file types.Key changes include:
Default File Type Handling:
FALLBACK_TENANTED_KEYSTORE_FILE_TYPE
constant and updated thedefaultFileType
method to returnJKS.name()
instead. [1] [2]defaultFileType
constant from theStoreFileType
enum.Error Handling and Logic Improvement:
getKeyStoreFileType
method to handle the super tenant domain name case separately and added improved error logging for unsupported file types.getKeystoreInstance
method to useStoreFileType.PKCS12.name()
for comparison instead of the removeddefaultFileType
constant.