Move keystore persistence manager implementations to org.wso2.carbon.utils component #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshanasbg
requested changes
Dec 12, 2024
| @@ -256,6 +256,7 @@ | |||
| <Export-Package> | |||
| !org.wso2.carbon.utils.resolver, | |||
| org.wso2.carbon, | |||
| org.wso2.carbon.keystore.persistence.*; | |||
There was a problem hiding this comment.
Lets make only the interfaces as exposed, keeping the Registry impl internal.
There was a problem hiding this comment.
Will change this with the next PR when introducing KeyStorePersistenceManagerFactory
....carbon.utils/src/main/java/org/wso2/carbon/keystore/persistence/model/KeyStoreMetadata.java
Outdated
Show resolved
Hide resolved
core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/util/KeyStoreManager.java
Outdated
Show resolved
Hide resolved
core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/util/KeyStoreManager.java
Outdated
Show resolved
Hide resolved
darshanasbg
previously approved these changes
Dec 12, 2024
|
PR builder started |
darshanasbg
previously approved these changes
Dec 12, 2024
darshanasbg
approved these changes
Dec 12, 2024
|
PR builder completed |
jenkins-is-staging
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12301531944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Move keystore persistence manager implementations to org.wso2.carbon.utils component
Details
This pull request includes significant changes to the key store management system, focusing on improving security and modularizing the code. The primary changes involve updating the
KeyStoreManagerclass, refactoring theKeyStorePersistenceManagerinterface, and modifying thepom.xmlfiles to reflect these updates.Key Store Management Improvements:
KeyStoreManagerclass to useKeyStoreModelfor key store operations, enhancing security by encrypting and decrypting passwords. [1] [2] [3] [4] [5] [6] [7]KeyStoreManagerto ensure sensitive data is securely handled.Code Refactoring:
KeyStorePersistenceManagerinterface to a new package,org.wso2.carbon.keystore.persistence, and updated its methods to useKeyStoreModel. [1] [2] [3] [4] [5]KeyStoreManager.javato reflect the new structure.Dependency and Configuration Updates:
pom.xmlfiles to update package exports and dependencies, ensuring the new package structure is correctly referenced. [1] [2]Testing and Data Holder Updates:
KeyStoreManagerTest.javato useOSGiDataHolderinstead ofCarbonCoreDataHolder. [1] [2]New Constants Class:
PersistenceManagerConstantsclass to centralize constants used in the persistence manager.