Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): remove deprecated defaultProps #278

Closed
wants to merge 1 commit into from
Closed

fix(react): remove deprecated defaultProps #278

wants to merge 1 commit into from

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Oct 9, 2024 •
edited
Loading

Purpose

defaultProps on functional components will be deprecated in the future.
See: facebook/react#16210

In this PR, I've remove the usage of deprecated defaultProps and refactored to use ES6 syntax for declaring default values for props.

Related Issues

Related PRs

  • N/A

Checklist

  • Figma Board Updated. (Mandatory for Icon and Component PRs. If you don't have access, please ask the core team to update it.)
  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@brionmario brionmario closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ditch defaultProps since it'll be deprecated in the future
1 participant
@brionmario