Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly destroy passthru worker pools during Listener destroy stage #2098

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

arunans23
Copy link
Member

@arunans23 arunans23 commented Sep 5, 2023

Resolves wso2/product-micro-integrator#2963

HTTP and HTTPS transport listeners are sharing the Passthru worker pool threads. Hence it is wrong to shutdown the worker pool for one Listener while the other Listener is active. This fix will ensure that the worker pool threads are shutdown when the listeners are destroyed.

@arunans23 arunans23 merged commit 472fdf7 into wso2:master Sep 15, 2023
1 check failed
@srinivaskancharla
Copy link

srinivaskancharla commented Mar 5, 2024

@arunans23 @isudana
Could you please validate if the issue reported here https://stackoverflow.com/questions/78078997/wso2mi-4-2-0-continous-socket-connection-errors-in-logs-when-pod-count-1

is similar to the one fixed? appreciate your response

@arunans23
Copy link
Member Author

@arunans23 @isudana Could you please validate if the issue reported here https://stackoverflow.com/questions/78078997/wso2mi-4-2-0-continous-socket-connection-errors-in-logs-when-pod-count-1

is similar to the one fixed? appreciate your response

No, this fix is done to improve the shutdown logic of passthrough transport listeners.

@srinivaskancharla
Copy link

Okay, thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful Shutdown - Open TCP Connection Handling is not working properly - MI 4.2.0
3 participants