New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make lint / make gosec failed if golangci-lint / gosec is not installed #1127

Closed

yosmoc opened this issue Oct 13, 2021 · 0 comments · Fixed by #1128

Labels

🐛 bug

Contributor

yosmoc commented Oct 13, 2021

What's broken?

$ make lint
golangci-lint cache clean
make: golangci-lint: No such file or directory
make: *** [Makefile:105: lint] Error 127

yosmoc added a commit to yosmoc/wtf that referenced this issue


          fix make lint and make gosec error (wtfutil#1127)

4dd1148

fix wtfutil#1127

Install golangci-lint / gosec, if it is not installed.
If we only support over go 1.16, we should use go install instead of go
get.

Use binary installation for golangci-lint because they recommends.
https://golangci-lint.run/usage/install/#local-installation

yosmoc mentioned this issue

fix make lint and make gosec error (#1127) #1128

Merged

senorprogrammer added the 🐛 bug label

yosmoc added a commit to yosmoc/wtf that referenced this issue


          Fix make lint and make gosec error

d0254dc

fix wtfutil#1127

Install golangci-lint / gosec, if it is not installed.
Use binary installation for golangci-lint because they recommend.
https://golangci-lint.run/usage/install/#local-installation

senorprogrammer closed this as completed in #1128

senorprogrammer pushed a commit that referenced this issue


          Fix make lint and make gosec error (#1128)

694c9ba

fix #1127

Install golangci-lint / gosec, if it is not installed.
Use binary installation for golangci-lint because they recommend.
https://golangci-lint.run/usage/install/#local-installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment