Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move CI to GitHub Actions and add tests against Ruby 2.7 - 3.3 #1

Merged
merged 7 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: test

on:
workflow_dispatch:
schedule:
- cron: '3 0 2 * *'
push:

jobs:
test:
runs-on: ubuntu-latest
name: Ruby ${{ matrix.ruby }}
strategy:
matrix:
ruby:
- '2.7'
- '3.1'
- '3.2'
- '3.3'
steps:
- uses: actions/checkout@v4
- name: Set up RUby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: lint
run: bundle exec rake standard
- name: test
run: bundle exec rake spec
2 changes: 1 addition & 1 deletion .standard.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# For available configuration options, see:
# https://github.com/testdouble/standard
ruby_version: 2.6
ruby_version: 2.7
6 changes: 0 additions & 6 deletions .travis.yml

This file was deleted.

4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## [Unreleased]
## [0.1.1] - 2024-08-15

* add tests against Ruby 2.7 - 3.3

## [0.1.0] - 2023-04-16

Expand Down
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ gemspec

group :development do
gem "rake", "~> 13.0"
gem "standard", "~> 1.3"
gem "standard", "~> 1.37"
gem "rubocop", "~> 1.62"
gem "solargraph", "> 0.38"
gem "yard", ">= 0.9.30"
end
Expand Down
2 changes: 1 addition & 1 deletion lib/sudachi-installer/dicts.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "faraday"
require "rexml"
require "xmlhasher"
require_relative "./downloader"
require_relative "downloader"

module SudachiInstaller
#
Expand Down
6 changes: 3 additions & 3 deletions lib/sudachi-installer/releases.rb
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
require "octokit"
require_relative "../sudachi-installer"
require_relative "./downloader"
require_relative "downloader"

module SudachiInstaller
#
# GitHub releases
#
class Releases
class ReleaseNotExist < Error; end # rubocop:disable
class AssetsAmbiguous < Error; end # rubocop:disable
class ReleaseNotExist < Error; end # rubocop:disable Layout/EmptyLineBetweenDefs
class AssetsAmbiguous < Error; end # rubocop:disable Layout/EmptyLineBetweenDefs

def initialize(httpclient: Faraday)
@octokit = Octokit::Client.new
Expand Down
4 changes: 2 additions & 2 deletions lib/sudachi-installer/resolver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ module SudachiInstaller
class Resolver
include SudachiInstaller

class ExecutableVersionNotDownloaded < Error; end # rubocop:disable
class DictionaryNotDownloaded < Error; end # rubocop:disable
class ExecutableVersionNotDownloaded < Error; end # rubocop:disable Layout/EmptyLineBetweenDefs
class DictionaryNotDownloaded < Error; end # rubocop:disable Layout/EmptyLineBetweenDefs

#
# @return [string]
Expand Down
2 changes: 1 addition & 1 deletion lib/sudachi-installer/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module SudachiInstaller
VERSION = "0.1.0" # rubocop:disable
VERSION = "0.1.1" # rubocop:disable
end
2 changes: 1 addition & 1 deletion sudachi-installer.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new do |spec|

spec.summary = "download and store Sudachi jar and dict files"
spec.homepage = "https://github.com/wtnabe/sudachi-installer-rb"
spec.required_ruby_version = ">= 2.6.0"
spec.required_ruby_version = ">= 2.7.0"

spec.metadata["allowed_push_host"] = "https://rubygems.org"

Expand Down