Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aet.sh with new options #275

Merged
merged 3 commits into from
Jul 2, 2018
Merged

update aet.sh with new options #275

merged 3 commits into from
Jul 2, 2018

Conversation

michalwronowski
Copy link
Contributor

Description

New options covered in aet.sh script including:

  • waiting for suite to be unlocked
  • ability to override domain specified in suite
  • running test against specific patterns

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

- wait for suite to be unlocked
- override domain specified in suite
- run against specific patterns
Copy link
Contributor

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @michalwronowski for this pull request.
There is an improvement from @mchrominski #271 to provide additional name param that will override suite name. But adjustments could be done in a separate PR.

@malaskowski
Copy link
Contributor

I've created #276 to remember about updating the script.

@malaskowski malaskowski merged commit f09b160 into master Jul 2, 2018
@malaskowski malaskowski deleted the feature/aet-client-sh branch July 2, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants