Feature/scroll modifier #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 15, 2018 11:47
tkaik
reviewed
Oct 16, 2018
tkaik
reviewed
Oct 16, 2018
...gnifide/aet/job/common/collectors/performance/clientside/ClientSidePerformanceCollector.java
Outdated
Show resolved
Hide resolved
tkaik
reviewed
Oct 16, 2018
core/jobs/src/main/java/com/cognifide/aet/job/common/modifiers/hide/HideModifier.java
Outdated
Show resolved
Hide resolved
tkaik
reviewed
Oct 16, 2018
.../jobs/src/main/java/com/cognifide/aet/job/common/utils/javaScript/JavaScriptJobExecutor.java
Outdated
Show resolved
Hide resolved
tkaik
reviewed
Oct 17, 2018
...java/com/cognifide/aet/job/common/modifiers/executejavascript/ExecuteJavaScriptModifier.java
Outdated
Show resolved
Hide resolved
tkaik
reviewed
Oct 17, 2018
core/jobs/src/main/java/com/cognifide/aet/job/common/modifiers/scroll/ParametersParser.java
Outdated
Show resolved
Hide resolved
Jakub-Izbicki
approved these changes
Oct 18, 2018
tkaik
reviewed
Oct 19, 2018
tkaik
reviewed
Oct 19, 2018
| Optional<String> xpath = Optional.ofNullable(parameters.get(XPATH_PARAM_NAME)) | ||
| .map(selector -> String.format(XPATH, selector)); | ||
|
|
||
| return specificPosition.isPresent() ? specificPosition |
There was a problem hiding this comment.
You can avoid neste inline ifs, e.g.
return Stream.of(specificPosition, css, xpath)
.filter(Optional::isPresent)
.findFirst()
.orElse(Optional.empty());
There was a problem hiding this comment.
Nice, refactored!
tkaik
reviewed
Oct 19, 2018
.../src/main/java/com/cognifide/aet/job/common/modifiers/scroll/ScrollModifierParamsParser.java
Show resolved
Hide resolved
tkaik
approved these changes
Oct 23, 2018
malaskowski
approved these changes
Oct 23, 2018
…e/scroll-modifier # Conflicts: # core/jobs/src/main/java/com/cognifide/aet/job/common/modifiers/resolution/ResolutionModifier.java # integration-tests/sanity-functional/src/test/java/com/cognifide/aet/sanity/functional/HomePageTilesTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new scroll modifier - user can scroll page to top/bottom or css/xpath selector
Motivation and Context
issue 386
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.