Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reintroduces sending multiple URLs in one message to collectors in order to boost performance.
Description
Changes made as a part of rerun functionality in #412 (in
CollectDispatcher
class among others) removed the possibility to send multiple URLs in a single message received byCollectorMessageListener
. This affected the performance because there is a new web driver created for each received message and this operation is resource consuming. By grouping multiple URLs in a single message it is possible to reuse a single web driver many times.I made some measurements using a dummy suit with 2 tests, each containing 10 URLs pointing to a server running on my local machine. The average times of 3 test runs for different URL package sizes are present in the following table:
Please keep in mind that only URLs within a single test are grouped (because each test can have different proxy setting etc.) so the performance gain is heavily dependent on the suit being tested,
Motivation and Context
Closes #431
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.