Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sending urls in packets #526

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

wblachowski
Copy link
Contributor

@wblachowski wblachowski commented Oct 2, 2019

This change reintroduces sending multiple URLs in one message to collectors in order to boost performance.

Description

Changes made as a part of rerun functionality in #412 (in CollectDispatcher class among others) removed the possibility to send multiple URLs in a single message received by CollectorMessageListener. This affected the performance because there is a new web driver created for each received message and this operation is resource consuming. By grouping multiple URLs in a single message it is possible to reuse a single web driver many times.

I made some measurements using a dummy suit with 2 tests, each containing 10 URLs pointing to a server running on my local machine. The average times of 3 test runs for different URL package sizes are present in the following table:

Package size Average suite runtime (in seconds)
1 33.22
3 24.07
6 19.22
9 27.04

Please keep in mind that only URLs within a single test are grouped (because each test can have different proxy setting etc.) so the performance gain is heavily dependent on the suit being tested,

Motivation and Context

Closes #431

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@tMaxx tMaxx merged commit a244dca into wttech:master Aug 6, 2020
@annabudziszewska
Copy link
Collaborator

Tested and accepted
Version: 3.3.1.SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AET sends always one url in package
5 participants