Fix/aa minor fixes after lando update #328
Conversation
…st, not a hash - taking service info by servie key does not make any sense)
There was a problem hiding this comment.
+1 for indentation fix, thanks!
settings.lando.php comes from here: wunderio/drupal-project#22, doesn't it work for you?
|
@aaleksu , could you please create a separate PR for indentation fix? Then we can merge it in and discuss about other changes further here. |
No, it does not work. I get empty database settings when I debug $databases variable in settings.php. |
The thing is that app will start successfully, but you won't get project running, because Drupal will not be able to connect to database (because of wrong (null) credentials). |
| ]; | ||
|
|
||
| if ($lando_info) { | ||
| $service_info_from_lando_env = function ($service) use ($lando_info) { |
There was a problem hiding this comment.
What is the purpose of defining this as a function? This makes it very difficult to understand what this code does and why it is there.
fixed indentation in .lando.yml
fixed settings.lando.php: getting database settings from lando info env (lando_info is a list, not a hash - taking service info by servie key does not make any sense)