rx-html (internal): Reduce the memory consumption of RenderingContext (…

…#3093) Fixes #3081
wvlet · Aug 4, 2023 · 2d0538b · 2d0538b
1 parent 6790f14
commit 2d0538b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/airframe-rx-html/.js/src/main/scala/wvlet/airframe/rx/html/DOMRenderer.scala b/airframe-rx-html/.js/src/main/scala/wvlet/airframe/rx/html/DOMRenderer.scala
@@ -112,14 +112,14 @@ object DOMRenderer extends LogSupport {
     * document.
     */
   private class RenderingContext() {
-    private val onRenderHooks = List.newBuilder[() => Unit]
+    private var onRenderHooks = List.empty[() => Unit]
 
     def onFinish(): Unit = {
-      onRenderHooks.result().foreach { f => f() }
+      onRenderHooks.reverse.foreach { f => f() }
     }
 
     def addOnRenderHook(f: () => Unit): RenderingContext = {
-      onRenderHooks += f
+      onRenderHooks = f :: onRenderHooks
       this
     }
   }

diff --git a/airframe-rx-html/src/main/scala/wvlet/airframe/rx/html/RxElement.scala b/airframe-rx-html/src/main/scala/wvlet/airframe/rx/html/RxElement.scala
@@ -73,7 +73,6 @@ abstract class RxElement(val modifiers: List[Seq[HtmlNode]] = List.empty) extend
 }
 
 object RxElement {
-
   def apply(a: RxElement): RxElement =
     new RxElement() {
       override def render: RxElement = a