Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Maya 2019 error #5

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Fix for Maya 2019 error #5

merged 3 commits into from
Jun 2, 2020

Conversation

j0yu
Copy link

@j0yu j0yu commented May 28, 2020 •
edited
Loading

See also PYSIDE-1063 and shotgunsoftware#95

Screen grabbing in tk-multi-snapshot causes the following error:

# Error: TypeError: file <maya console> line 1: 'PySide2.QtGui.QScreen.grabWindow' called with wrong argument types:
  PySide2.QtGui.QScreen.grabWindow(int, int, int, int, int)
Supported signatures:
  PySide2.QtGui.QScreen.grabWindow(quintptr, int = 0, int = 0, int = -1, int = -1) #

Not an issue in Maya 2020 which uses a more recent PySide2/Qt version

Fixes

  • Old PySide2 quintptr type found in Maya 2019, see also PYSIDE-1063

@j0yu j0yu requested a review from Liametc May 28, 2020 17:31
@j0yu j0yu self-assigned this May 28, 2020
@j0yu j0yu marked this pull request as ready for review June 1, 2020 16:40
@j0yu j0yu changed the title WIP: Fix for Maya 2019 error Fix for Maya 2019 error Jun 1, 2020
@j0yu
Copy link
Author

j0yu commented Jun 2, 2020

Gonna split into 2 PRs, I'll automatically merge in the follow-up one

@j0yu j0yu merged commit e54da65 into master Jun 2, 2020
@j0yu j0yu deleted the fix-maya-2019-quintptr branch June 2, 2020 10:07
j0yu pushed a commit that referenced this pull request Jun 2, 2020
@j0yu
Fix for Maya 2019 error (#5)
3bfa634 
* Initial fix

* Py3 friendly long

* Fixed missing :, extra comment space
@j0yu j0yu mentioned this pull request Jun 2, 2020
Open
j0yu pushed a commit that referenced this pull request Nov 5, 2020
Fix for Maya 2019 error (#5)
c25c4cc 
* Initial fix

* Py3 friendly long

* Fixed missing :, extra comment space
j0yu pushed a commit that referenced this pull request Mar 10, 2021
Fix for Maya 2019 error (#5)
526b2a8 
* Initial fix

* Py3 friendly long

* Fixed missing :, extra comment space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liametc Liametc Liametc approved these changes

Assignees

@j0yu j0yu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j0yu @Liametc