Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows bump WindowsTargetPlatformMinVersion #23

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

TatianaKapos
Copy link

In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72

@TatianaKapos
Copy link
Author

@creambyemute would you mind looking at this PR when you have the chance? :) It blocks RNW apps from using .72

@creambyemute
Copy link
Member

@TatianaKapos
LGTM. In our project, which uses rn-sketch-canvas we are using MinVersion 18362 anyways and Target Version of 19041 so it should be safe to merge 👍 .

@creambyemute creambyemute merged commit 7f0a9a1 into wwimmo:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants