Skip to content

Commit

Permalink
updated github actions configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
wwmm committed Apr 25, 2024
1 parent 3ce033c commit ec2472d
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions .github/workflows/CI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,13 @@ jobs:
- name: creating the executable
run: |
Xvfb :0 -screen 0 1024x768x16 &
DISPLAY=:0.0 wine python -c "import os;pythonpath = os.getenv('PYTHONPATH','');print(os.getenv('PYTHONPATH'))"
DISPLAY=:0.0 wine cmd < gen_win_exe.bat
killall Xvfb
- name: Upload Package Archive
uses: actions/upload-artifact@v4.3.1
with:
name: wwplot-git-${{ env.GITHUB_HEAD_SHA }}-x86_64.exe
path: dist
path: dist/wwplot.exe
if-no-files-found: error

# on a pull_request event in github actions, the tests are not run on the head branch of the PR, rather they are run on the merge commit of head merged into the base branch
# this means the latest commit in github actions, which is used for build artifact names is a commit that does not exist in the repository
# so on pull requests we create a user-friendly string to use in place of the merge commit sha, otherwise we just use the normal git HEAD sha.
# - id: get_commit_desc
# run: |
# if [[ ${{ github.event_name }} == 'pull_request' ]]; then
# echo "github_commit_desc=merge-${{ env.GITHUB_PR_HEAD_SHA }}-into-${{ env.GITHUB_PR_BASE_SHA }}" >> $GITHUB_OUTPUT
# else
# echo "github_commit_desc=${{ env.GITHUB_HEAD_SHA }}" >> $GITHUB_OUTPUT
# fi

0 comments on commit ec2472d

Please sign in to comment.