Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wx.lib.agw.aui sometimes shows "ghost" docking guide. #2364

Closed
tianzhuqiao opened this issue Mar 8, 2023 · 0 comments · Fixed by #2599
Closed

wx.lib.agw.aui sometimes shows "ghost" docking guide. #2364

tianzhuqiao opened this issue Mar 8, 2023 · 0 comments · Fixed by #2599

Comments

@tianzhuqiao
Copy link

Operating system: MacOS 13.2.1
wxPython version & source: 4.2.0
Python version & source: 3.9.5

Description of the problem:
As shown in the following example, the center docking guide close to the bottom is not valid.

aui_drop_ghost_fail

Looks like the issue comes from the following line (as it doesn't check if the notebookRoot is shown).

Phoenix/wx/lib/agw/aui/framemanager.py

Line 9372 in 2f2624b

if not notebookRoot or not notebookRoot.IsDocked():

After change it to the following line, the ghost docking guide will not show.

if not notebookRoot or not notebookRoot.IsDocked() or not notebookRoot.IsShown():

aui_drop_ghost_pass
@infinity77 infinity77 mentioned this issue Sep 5, 2024
Merged
@swt2c swt2c closed this as completed in 6ae09a2 Sep 5, 2024
swt2c added a commit that referenced this issue Sep 5, 2024
@swt2c
Merge pull request #2599 from infinity77/patch-3
14b6e5d 
Possible fix for #2364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Possible fix for #2364 infinity77/Phoenix
1 participant
@tianzhuqiao