Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios look up table issue #46

Open
R3l0ad3d opened this issue May 16, 2019 · 7 comments
Open

ios look up table issue #46

R3l0ad3d opened this issue May 16, 2019 · 7 comments

Comments

@R3l0ad3d
Copy link

I use look up table for filter image in ios objective c . but filter quality is very low . but in android device same look up table filter quality is good . how can i fix this . i provide code and screen shot please check .
my code
char* const rulesString = "@adjust lut 9.png";
cgeSetLoadImageCallback(loadImageCallback, loadImageOKCallback, nil);
UIImage* image = cgeFilterUIImage_MultipleEffects([UIImage imageNamed:@"raw"], rulesString, 1.0f, nil);
self.ivOutputImage.image = image;

raw image ,
raw

lookup table
1

and expected image
1a

but my output is
Screenshot 2019-05-16 at 4 52 25 PM

@wysaid
Copy link
Owner

wysaid commented May 16, 2019

How did your expected image generated?
I just tried the lut. The output is right.

@wysaid
Copy link
Owner

wysaid commented May 16, 2019

image

@R3l0ad3d
Copy link
Author

I also try in your tools . its ok . but when i try to do this in ios then output quality lose .

@wysaid
Copy link
Owner

wysaid commented May 30, 2019

I see. My lut function skipped the blue color mix, I will fix in one or two days.

@R3l0ad3d
Copy link
Author

R3l0ad3d commented Jun 1, 2019

thanks . if you fix please inform me . i think you know Open GL is deprecated in ios . will you convert it to Metal ?

@wysaid
Copy link
Owner

wysaid commented Jun 1, 2019

@R3l0ad3d Sure, but it may take me some time.

@wysaid
Copy link
Owner

wysaid commented Jun 3, 2019

I see. My lut function skipped the blue color mix, I will fix in one or two days.

Fixed. Please try again with the latest implementation.

wysaid added a commit to wysaid/android-gpuimage-plus that referenced this issue Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants