New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复两个颜色相关 bug #12

Merged

wysaid merged 3 commits into wysaid:master from chirsz-ever:fix_bugs_2020_04

Apr 12, 2020

Collaborator

chirsz-ever commented Apr 12, 2020

#11 中：

putpixels和putpixels_f像素颜色赋值方式修正，由BGR改为RGB

clearviewport清除视口区域是直接用bar糊上去的，这样颜色实际是填充颜色，建议修正为用背景颜色填充。

请 @GWMforget1997 测试

chirsz-ever added 3 commits

April 12, 2020 16:24


          修复 putpixel* 与 getpixel* 中颜色格式问题

a47f71b

统一为在外部使用 RGB 格式，在显存区中使用 BGR 格式
增加 `BGRTORGB` 宏，清晰语义


          修正 ege::clearviewport 的行为

9a53b2d


          Revert "修复 putpixel* 与 getpixel* 中颜色格式问题"

15243c0

统一使用 ARGB 格式颜色：从低地址到高地址各字节分别表示 B G R A 分量

Collaborator

yixy-only commented Apr 12, 2020

测试已经完成，可以merge了 @wysaid

wysaid merged commit a9a6fe8 into wysaid:master

chirsz-ever deleted the fix_bugs_2020_04 branch

April 12, 2020 17:21

FrankHB commented Apr 14, 2020 •

edited

Loading

~~早该修复了。不过，确定这里的修复是全的么。~~
都统一 BGRA8888 还行。

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

04904eb

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

df291e6

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

Owner

wysaid commented Apr 27, 2020

妙啊

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

b916331

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

8b308a0

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

e7d7174

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

1c0da3c

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

0e7cca0

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

0ae0772

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

1a922d5

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

91b979e

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

be86987

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

f7ea477

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

9b5cf5e

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

f9a857f

另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

ba464d3

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

499ba7a

参见提交 9788fa0 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

741d2c0

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

b663505

参见提交 9788fa0 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

d25fce7

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

249eadd

参见提交 bbc890f 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

e551f84

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

a900ef2

参见提交 bbc890f 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

ba812a0

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

59ce689

参见提交 bbc890f 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

5de4ef6

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

ff16a45

参见提交 bbc890f 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

26b9b65

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

6efb9e2

参见提交 0243835 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

0a7d785

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

ad11222

参见提交 0243835 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

50769ac

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

3ce1bd5

参见提交 fa73c87 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

7fce752

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

151c957

参见提交 fa73c87 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

603ebaa

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

参见提交 fa73c87 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

51f856b

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

655656e

参见提交 fa73c87 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

0bc4056

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/: 修改 color_t 格式。

35dbee1

参见提交 1f90cd7 。
另见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

FrankHB added a commit to FrankHB/YEGE that referenced this pull request


          EGE/src/ege/viewport.cpp: 函数 clearviewport 使用背景颜色填充。

c63d8dc

参见 wysaid/xege#12 。

Signed-off-by: FrankHB <frankhb1989@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet