create token card #149
create token card #149
Conversation
o0Ignition0o
force-pushed
the
igni/create_token_card
branch
from
47bacf4 to
2b81030
Compare
|
Hello, apologies for the late reply. We are working on getting up to speed on pull requests. May I ask if you are still interested in merging this (we are!) that you rebase? Thank you. |
|
Hey there! I definitely am, but I m not really sure how to proceed from here :/ if you have any pointers I'd love to push it through the finish line |
|
Sure! To avoid huge branches (I personally find it hard to to seperate visually if merges are from a commit too far away) lets rebase this on master. Then, since this is an auto-generated file I think we'll need to get the codegen to build it automatically rather than rely on manual patches, otherwise this may get overwritten. I think in the future, we may move all the generated code into its own module to make the distinction clearer but in the mean time we'll have to make do. edit: I just noticed you also opened a PR on my fork as well, feel free to ask for some more detailed instructions and we'll get this merged |
|
@o0Ignition0o any update about this? Otherwise, I am happy to continue the PR based on Arlyon pointers. |
|
I unfortunately haven’t had time to do so, I’d be happy to see you take it to the finish line |
part of #1, Card token create support.
please let me know if there's anything I can do to improve this.